Removed custom code for assimp < 5.0.1. #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
1 similar comment
|
retest this please |
Assimp PLY bug is still present in 5.0.0. PLY custom importer is hence still required. OBJ custom importer is required for mesh files > 256MB. This reverts commit ca894d1.
So testImages should pass even if we update assimp. Updated io/assimpImporters/BaseImporter.h Now the vtable should match even with assimp > 5.0.1. So the segfault should be fixed. Fixed compile error with BRAYNS_USE_ASSIMP disabled.
NadirRoGue
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding assimp as a submodule is very complicated, that is why we only removed the code that makes Brayns crash with assimp 5.0.1.