Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes #860

Merged
merged 4 commits into from
Dec 16, 2019
Merged

Various fixes #860

merged 4 commits into from
Dec 16, 2019

Conversation

favreau
Copy link
Member

@favreau favreau commented Nov 14, 2019

No description provided.

tolokoban
tolokoban previously approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@tolokoban tolokoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain to Nadir and I what this plugin does?

@favreau favreau force-pushed the master branch 2 times, most recently from fd0df4d to 7373aa3 Compare December 4, 2019 18:46
@favreau favreau requested review from tolokoban and removed request for tolokoban December 4, 2019 18:48
@favreau favreau changed the title Added Graphs plugin Various fixes Dec 4, 2019
@favreau
Copy link
Member Author

favreau commented Dec 4, 2019

I only removed the duplicated code, not the feature.

tolokoban
tolokoban previously approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@tolokoban tolokoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me. ;-)

@favreau favreau merged commit 090a230 into BlueBrain:master Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolokoban tolokoban tolokoban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@favreau @tolokoban