Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed transform issue with scaling. For more details, see: https://to… #846

Merged
merged 3 commits into from
Dec 19, 2019

Conversation

tolokoban
Copy link
Contributor

For more details, see: https://tokoban.github.io/web-brayns/rotation-center.html

Now, place a model into the space, you will give :

  • its scale,
  • the location where you want to find it if no rotation occurs,
  • the rotation center,
  • the quaternion of rotation around that center.

Then, if you want your model to rotate around its own center, you must set the rotation center to be equal to the location.

@favreau
Copy link
Member

favreau commented Oct 17, 2019

Thanks for the PR. But do not merge until this is validated with the Plugins, mainly the molecular systems. This will have impact on the loading of the current notebooks, and the scenes that I am currently working on.

@tolokoban
Copy link
Contributor Author

tolokoban commented Oct 17, 2019

Ok, no problem.
How can I test it against the molecular system?

@tolokoban
Copy link
Contributor Author

Hi Cyrille!
Did you get a chance to test this change against your Molecular System plugin?

@favreau
Copy link
Member

favreau commented Nov 19, 2019

Looks good to me.

@tolokoban
Copy link
Contributor Author

This fix has already been merged in Nadir's branch.

@tolokoban tolokoban closed this Dec 19, 2019
@tolokoban tolokoban reopened this Dec 19, 2019
@tolokoban tolokoban merged commit 4e6500b into BlueBrain:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants