feat(cpp): add light manager #749
Merged
+1,016
−460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
karjonas
commented
Mar 21, 2019
karjonas
commented
- Add a light manager to the scene
- Add spotlight and quadlight light sources, only supported in OSPRay for now
- Expose adding/removing of lights as RPCs
karjonas
force-pushed
the
light_manager
branch
2 times, most recently
from
179abcd to
160912d
Compare
hernando
reviewed
Mar 22, 2019
brayns/engine/LightManager.h
Outdated
|
|
||
| /** | ||
| * @brief addQuadLight Creates a quad light. The quad light is a planar, | ||
| * procedural area light source emitting uniformly on one side into the |
brayns/engine/LightManager.h
Outdated
|
|
||
| /** | ||
| * @brief addQuadLight Creates a quad light. The quad light is a planar, | ||
| * procedural area light source emitting uniformly on one side into the |
There was a problem hiding this comment.
This is not entirely clear to me. If each point in the light surface emit uniformly in the half-space, the integral over the area doesn't produce a uniform distribution over a solid angle (as I understand the sphere light does). For that to happen the area needs to be infinite. I would be more careful with the wording.
* Add a light manager to the scene * Add spotlight and quadlight light sources, only supported in OSPRay for now * Expose adding/removing of lights as RPCs
|
I rewrote this PR a bit so that each light is actually a different class without any property map. The light manager now stores the ids for the added lights. The lights serialization is done with a generic RPCLight class which is populated in the rockets plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.