fix(js): ignore app bar height when calculating default snapshot height #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribal-tec
reviewed
Jan 31, 2019
| width: number; | ||
| height: number; | ||
| } { | ||
| const [width, height] = [ | ||
| window.innerWidth, | ||
| window.innerHeight | ||
| window.innerHeight - (isWidthDown('xs', currentWidth) ? 64 : 56) |
There was a problem hiding this comment.
magic number looks wrong. why not using the current viewport of Brayns?
There was a problem hiding this comment.
I made some consts now. We cannot use the viewport from Brayns because other clients could change that and the snapshot default size should be the size of the browser's viewport that the snapshot is taken in.
rolandjitsu
force-pushed
the
fix/snapshot-size
branch
from
7789151 to
729e750
Compare
rolandjitsu
force-pushed
the
fix/snapshot-size
branch
from
729e750 to
ca17a0f
Compare
tribal-tec
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.