Fix loading of NPOT textures, support loading raw volumes from blob #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use FreeImage_GetBits() as this does not return the real raw pixels that we expect.
hernando
reviewed
Jan 28, 2019
| const auto pitch = FreeImage_GetPitch(image.get()); | ||
| const auto channels = 4; | ||
|
|
||
| std::vector<unsigned char> rawData(height * pitch); |
There was a problem hiding this comment.
Is this correct? Shouldn't it be height * pitch * channels?
There was a problem hiding this comment.
Yes it is correct. bytesPerPixel would be needed if we would load float textures or something similar.
There was a problem hiding this comment.
In fact I was not talking about the bytes per Pixel, but the number of channels. But if you tell me that pitch is in bytes and not number of elements, that would explain why this code works (and would always do regardless of channels and bytes per pixel).
There was a problem hiding this comment.
That's what apparently the pitch in FreeImage is, yes.
karjonas
reviewed
Jan 28, 2019
hernando
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.