Add description for Property and commandline generation #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karjonas
reviewed
Nov 30, 2018
tribal-tec
force-pushed
the
propertymap_cmdline
branch
from
25bb07f to
f6eedee
Compare
|
ping |
karjonas
previously approved these changes
Dec 3, 2018
tribal-tec
force-pushed
the
propertymap_cmdline
branch
from
f6eedee to
1b8795b
Compare
|
Had another iteration where I added generic support for enums (with one minor limitation for integer enums), provided more docs & tests, and fix the casing (camelCase property to hyphenated-case for cmdline option). |
tribal-tec
force-pushed
the
propertymap_cmdline
branch
from
1b8795b to
9db0e9e
Compare
|
retest this please |
tribal-tec
force-pushed
the
propertymap_cmdline
branch
from
9db0e9e to
9ca085b
Compare
hernando
reviewed
Dec 4, 2018
| { | ||
| public: | ||
| PropertyMap() = default; | ||
| enum class Type |
There was a problem hiding this comment.
that's a different refactoring, no?
| { | ||
| assertValidType<T>(); | ||
|
|
||
| if (std::is_same<T, double>::value) |
There was a problem hiding this comment.
I would suggest to use if constexpr if it wasn't C++17, but the compiler should be able to optimize out the dead branches anyway.
| template <typename T> | ||
| T _castValue(const boost::any& v) const | ||
| { | ||
| _checkType<T>(); |
There was a problem hiding this comment.
Any reason for not relying on boost::bad_cast? If is performing undesired type promotions?
There was a problem hiding this comment.
Don't know. I moved the code only, @karjonas was the original author of that.
tribal-tec
force-pushed
the
propertymap_cmdline
branch
from
9ca085b to
46cc99d
Compare
hernando
approved these changes
Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.