Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BBIC volume plugin #619

Merged
merged 2 commits into from
Nov 29, 2018
Merged

Add BBIC volume plugin #619

merged 2 commits into from
Nov 29, 2018
+1,884 −3

Conversation

tribal-tec
Copy link
Contributor

No description provided.

@tribal-tec
Copy link
Contributor Author

retest this please

@tribal-tec
Copy link
Contributor Author

retest this please

karjonas
karjonas reviewed Nov 28, 2018
View reviewed changes
rdumusc
rdumusc reviewed Nov 28, 2018
View reviewed changes
Copy link

@rdumusc rdumusc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see bbic back :-) I think some of the code could be cleaned a bit more, but good in general

@tribal-tec tribal-tec force-pushed the bbic branch 2 times, most recently from 30d5baf to c8ea35d Compare November 28, 2018 16:37
@tribal-tec
Copy link
Contributor Author

Thanks for the comments. Looks better now. Was indeed some old code, hence it's better if it's pushed and more maintained.

@tribal-tec
Copy link
Contributor Author

retest this please

@tribal-tec
Copy link
Contributor Author

ping

@tribal-tec
Copy link
Contributor Author

retest this please

@tribal-tec tribal-tec merged commit ab38596 into BlueBrain:master Nov 29, 2018
@tribal-tec tribal-tec deleted the bbic branch November 29, 2018 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karjonas karjonas

@rdumusc rdumusc

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tribal-tec @karjonas @rdumusc