Add a target state to the camera. Bug fixes. #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chevtche
changed the title
rolandjitsu
approved these changes
Oct 23, 2018
hernando
reviewed
Oct 23, 2018
| @@ -63,14 +63,18 @@ void FlyingModeManipulator::dragLeft(const Vector2i& to, const Vector2i& from) | |||
|
|
|||
| void FlyingModeManipulator::dragRight(const Vector2i& to, const Vector2i& from) | |||
| { | |||
| const float distance = -(to.y() - from.y()) * getMotionSpeed(); | |||
| const float distance = -(to.y() - from.y()) * | |||
| DEFAULT_MOUSE_MOTION_SPEED_MULTIPLIER * | |||
There was a problem hiding this comment.
This looks like getMotionSpeed and getRotationSpeed should return smaller values. I would do that instead of adding this multiplication by DEFAULT_MOUSE_... everywhere.
I have to test myself how your manipulator works now before judging if this is an improvement.
There was a problem hiding this comment.
No you can't. If you do so keyboard mouvements are to slow. Believe me, it's an improvement :)
There was a problem hiding this comment.
I find the rotation quite slow and panning too fast. In any case, we won't use this manipulator so much so feel free to leave it as it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.