Throw exception on invalid color scheme name. #534
Conversation
| "protein-atoms", | ||
| "protein-chains", | ||
| "protein-residues"}; | ||
| const std::array<std::string, 12> COLOR_SCHEMES = {"none", |
There was a problem hiding this comment.
That was not possible.
| "protein-by-id", | ||
| "protein-atoms", | ||
| "protein-chains", | ||
| "protein-residues"}; |
There was a problem hiding this comment.
Hmm, this design is not very nice to allow plugin specific extensions. It looks to me that in the end, the color scheme should be a dynamic property.
There was a problem hiding this comment.
I will leave it like this until it is removed.
There was a problem hiding this comment.
Sure. I was just commenting that we will need to change it eventually.
| "target|protein-by-id|protein-atoms|protein-chains|protein-" | ||
| "residues]")(PARAM_GEOMETRY_QUALITY.c_str(), | ||
| po::value<std::string>(), | ||
| "Geometry rendering quality [low|medium|high]")( |
There was a problem hiding this comment.
The whole code block for adding options is unreadable. Can you do some hand formatting to all the options and add // clang-format off // clang-format surrounding it?
|
|
||
| if (!matchedScheme) | ||
| throw po::error("No match for color scheme '" + colorScheme); | ||
| } |
There was a problem hiding this comment.
Does it look shorter with std::find? (in fact, that would be a reason for using std::array)
|
This is legacy and will/should be moved to a plugin eventually. Not sure if it's worth spending any more time on it. |
No description provided.