Precision must be double for JSON #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandjitsu
reviewed
Aug 22, 2018
brayns/common/Transformation.h
Outdated
| @@ -37,29 +37,29 @@ class Transformation : public BaseObject | |||
| public: | |||
| Transformation() = default; | |||
|
|
|||
| Transformation(const Vector3f& translation, const Vector3f& scale, | |||
| const Quaternionf& rotation, const Vector3f& rotationCenter) | |||
| Transformation(const Vector3d& translation, const Vector3f& scale, | |||
There was a problem hiding this comment.
Shouldn't the scale and rotationCenter also use Vector3d?
brayns/common/Transformation.h
Outdated
| Quaternionf _rotation; | ||
| Vector3f _rotationCenter{0.f, 0.f, 0.f}; | ||
| Vector3d _translation{0., 0., 0.}; | ||
| Vector3d _scale{1.f, 1.f, 1.f}; |
brayns/common/Transformation.h
Outdated
| Vector3d _translation{0., 0., 0.}; | ||
| Vector3d _scale{1.f, 1.f, 1.f}; | ||
| Quaterniond _rotation; | ||
| Vector3d _rotationCenter{0.f, 0.f, 0.f}; |
brayns/common/Transformation.h
Outdated
| @@ -93,7 +93,7 @@ inline Transformation operator*(const Transformation& a, | |||
| a.getRotationCenter()}; | |||
| } | |||
|
|
|||
| inline Boxf transformBox(const Boxf& box, const Transformation& trafo) | |||
| inline Boxd transformBox(const Boxd& box, const Transformation& trafo) | |||
tests/brayns.cpp
Outdated
|
|
||
| const auto& animParams = pm.getAnimationParameters(); | ||
| BOOST_CHECK_EQUAL(animParams.getFrame(), 0); | ||
|
|
||
| const auto& volumeParams = pm.getVolumeParameters(); | ||
| BOOST_CHECK_EQUAL(volumeParams.getDimensions(), brayns::Vector3ui(0, 0, 0)); | ||
| BOOST_CHECK_EQUAL(volumeParams.getElementSpacing(), | ||
| brayns::Vector3f(1.f, 1.f, 1.f)); | ||
| brayns::Vector3d(1.f, 1.f, 1.f)); |
tests/brayns.cpp
Outdated
| BOOST_CHECK_EQUAL(volumeParams.getOffset(), | ||
| brayns::Vector3f(0.f, 0.f, 0.f)); | ||
| brayns::Vector3d(0.f, 0.f, 0.f)); |
tribal-tec
force-pushed
the
precision
branch
2 times, most recently
from
b2ca871 to
278ebf4
Compare
JSON comes with infinite precision and if incoming numbers are truncated to float, we can not guarantee to re-broadcast the same numbers again. Float is still supported nonetheless in general, but no longer for PropertyMap.
rolandjitsu
approved these changes
Aug 22, 2018
karjonas
approved these changes
Aug 22, 2018
| @@ -33,6 +33,15 @@ namespace brayns | |||
| ospSet##OSP(ospObject, prop->name.c_str(), \ | |||
| prop->get<std::array<TYPE, NUM>>().data()); \ | |||
| break; | |||
| #define SET_ARRAY_FLOAT(OSP, NUM) \ | |||
There was a problem hiding this comment.
I think we could make these defines templated functions. For another PR though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.