Add suggestions for unrecognized command line options. #526
Conversation
| nameStrip.erase(std::remove(nameStrip.begin(), nameStrip.end(), '-'), | ||
| nameStrip.end()); | ||
|
|
||
| // Also suggest options containing the substring |
There was a problem hiding this comment.
Maybe these suggestions should go first
|
|
||
| throw po::error(errorMessage); | ||
| } | ||
|
|
There was a problem hiding this comment.
Move to a separate _processUnrecognizedOptions function?
| col[0] = i + 1; | ||
| for (unsigned int j = 0; j < len2; j++) | ||
| // note that std::min({arg1, arg2, arg3}) works only in C++11, | ||
| // for C++98 use std::min(std::min(arg1, arg2), arg3) |
| // Merge suggestions giving precedence to substrings | ||
| auto output = subStringOptions; | ||
| output.insert(std::end(output), std::begin(levenshteinOptions), | ||
| std::end(levenshteinOptions)); |
There was a problem hiding this comment.
Just a comment, why do you use std::end(..) instead of calling foo.end()? I would understand it in a template function, but here it makes the code less readable. I'd even say the same for using insert.
Don't you find this more readable and shorter to type:
for (const auto& option : levenshteinOptions)
output.push_back(option)
There was a problem hiding this comment.
Yes, that is better. I would like to see a 'vector += other_vector' or 'vector.append(other_vector)' in the standard library.
| constexpr size_t MAX_SUGGESTIONS = 7; | ||
|
|
||
| for (const auto& optionName : options) | ||
| std::vector<std::string> subStringOptions; | ||
| std::vector<std::string> levenshteinOptions; |
There was a problem hiding this comment.
Why two vectors that need concatenation later on? The original code was fine, I was just suggesting to move the substrings options up.
There was a problem hiding this comment.
I think it is easier to just keep them separated since then I can clear just the levenshtein vector in the loop.
| void ParametersManager::_processUnrecognizedOptions( | ||
| const std::vector<std::string>& unrecognizedOptions) const | ||
| { | ||
| if (!unrecognizedOptions.empty()) |
There was a problem hiding this comment.
if (unrecognizedOptions.empty())
return;
Example: