Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broadcast of animation params and scene updates #519

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

tribal-tec
Copy link
Contributor

No description provided.

Animation previous/next frame updates from clients were not properly broadcasted.
Scene updates were too frequent and semantically wrong.
@tribal-tec tribal-tec requested a review from rolandjitsu August 16, 2018 08:20
Copy link
Contributor

@rolandjitsu rolandjitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Though scene is still broadcasted on every frame, so there is no way to get around that I suppose?

@tribal-tec
Copy link
Contributor Author

Not right now. The different parts (models, clip planes, simulation) of the scene which require a broadcast have to be properly identified and handled.

@tribal-tec tribal-tec merged commit d74faa4 into BlueBrain:master Aug 16, 2018
@tribal-tec tribal-tec deleted the anim_fixes branch August 16, 2018 09:11
@tribal-tec tribal-tec added the bug label Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants