Reworked simulations renderers #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karjonas
reviewed
Aug 14, 2018
| @@ -1,9 +1,7 @@ | |||
| /* Copyright (c) 2015-2016, EPFL/Blue Brain Project | |||
| /* Copyright (c) 2015-2017, EPFL/Blue Brain Project | |||
| uint32 transferFunctionSize; | ||
|
|
||
| // Alpha correction | ||
| float alphaCorrection; | ||
| }; | ||
|
|
||
| inline varying vec4f |
There was a problem hiding this comment.
A similar function is used also for the simulation renderer, can they be merged?
added 2 commits
August 14, 2018 14:57
favreau
changed the title
favreau
changed the title
favreau
force-pushed
the
master
branch
2 times, most recently
from
30f2623 to
7ffcb6f
Compare
|
Retest this please |
karjonas
reviewed
Aug 14, 2018
| namespace brayns | ||
| { | ||
| /** | ||
| * The AbstractRenderer class implements a base renderer for all Brayns custom |
| // Value offset is out of range, return error color | ||
| return color; | ||
|
|
||
| // Normalize the value according colormap size |
|
|
||
| struct BasicSimulationRenderer | ||
| { | ||
| SimulationRenderer abstract; |
There was a problem hiding this comment.
Is there a better name than abstract, like simulation_renderer or something?
There was a problem hiding this comment.
Renamed to super (to remain consistent with OSPRay)
| { | ||
| AbstractRenderer abstract; | ||
| SimulationRenderer abstract; |
There was a problem hiding this comment.
Is there a better name than abstract, like simulation_renderer or something?
|
retest this please |
|
Why is tests/files/images/testdataallmini50color.png updated? Should it not be the same still? |
karjonas
approved these changes
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g speed