Add model properties to allow updates on model data from plugins #506
Conversation
| { | ||
| const RpcParameterDescription desc{ | ||
| METHOD_GET_MODEL_PROPERTIES, | ||
| "Get the properties of the given model", "ids", |
There was a problem hiding this comment.
I thought that get model properties is for a single model:
RPC get-model-properties {id: 'some model id'}
There was a problem hiding this comment.
Yes, it is. Have to fix this description.
| inline void init(brayns::ModelProperties* s, ObjectHandler* h) | ||
| { | ||
| h->add_property("id", &s->modelID); | ||
| h->add_property("properties", &s->properties); |
There was a problem hiding this comment.
Are the params for set model props:
{
id: 1,
properties: {
ping: true
}
}or:
{
id: 1,
ping: true
}?
Second would make more sense, unless that's difficult to implement.
There was a problem hiding this comment.
It's first option for now. Ideally, the RPC would have 2 arguments, but that's not supported right now in Rockets iirc. The second option is quite unnatural, as the 'id' is not a property of the model properties, it's only needed to find the model.
There was a problem hiding this comment.
Ok. Does this apply for broadcast and get or is it only the set?
There was a problem hiding this comment.
set- and broadcast. get- is just the properties, the ID is the input for the get- request.
tribal-tec
force-pushed
the
model_props
branch
2 times, most recently
from
7db80d5 to
f403a4d
Compare
tribal-tec
force-pushed
the
model_props
branch
from
f403a4d to
4507034
Compare
No description provided.