Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposed volume alpha correction parameters to WS API #488

Merged
merged 4 commits into from
Aug 6, 2018

Conversation

favreau
Copy link
Member

@favreau favreau commented Aug 2, 2018

No description provided.

@favreau favreau requested a review from tribal-tec August 2, 2018 23:18
Copy link
Contributor

@tribal-tec tribal-tec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Denied!

@tribal-tec tribal-tec dismissed their stale review August 4, 2018 16:22

Except for the alpha correction, the rest looks fine.

if (shadingEnabled)
{
uniform int i = 0;
// for (uniform int i = 0; i <
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@favreau favreau merged commit 5bf6028 into BlueBrain:master Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants