Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly handle image_stream_fps == 0 to disable streaming #453

Merged
merged 1 commit into from
Jul 5, 2018
Merged

Explicitly handle image_stream_fps == 0 to disable streaming #453

merged 1 commit into from
Jul 5, 2018

Conversation

tribal-tec
Copy link
Contributor

No description provided.

@tribal-tec tribal-tec requested a review from favreau July 5, 2018 16:32
rolandjitsu
rolandjitsu approved these changes Jul 5, 2018
View reviewed changes
Copy link
Contributor

@rolandjitsu rolandjitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the client be allowed to set this to 0? In the UI I do not allow the user to be below 1.

@tribal-tec
Copy link
Contributor Author

It can be used to disable the streaming. Is useful if the braynsViewer is used where the images congest the link.

@tribal-tec tribal-tec merged commit 35805d3 into BlueBrain:master Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolandjitsu rolandjitsu rolandjitsu approved these changes

@favreau favreau Awaiting requested review from favreau

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tribal-tec @rolandjitsu