Fix segfault when using Viewer and browser UI #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the browser is connecting to Brayns it changes the viewport size in preRender(). Since the Viewer is unaware of this change then the Viewer will try to draw the resized buffer with an incorrect viewport size. If the buffer is shrunk then this can lead to a segfault. Now instead, the actual width and height of the buffer is stored when rendering and then used when the Viewer is drawing.
tribal-tec
approved these changes
Jun 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the browser is connecting to Brayns it changes the viewport size in preRender(). Since the Viewer is unaware of this change then the Viewer will try to draw the resized buffer with an incorrect viewport size. If the buffer is shrunk then this can lead to a segfault. Now instead, the actual width and height of the buffer is stored when rendering and then used when the Viewer is drawing.