Remove ImageMagick, use FreeImage instead #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribal-tec
force-pushed
the
master
branch
2 times, most recently
from
6a684d6 to
5e603ef
Compare
favreau
approved these changes
Jun 7, 2018
rdumusc
reviewed
Jun 7, 2018
| BYTE* pixels = NULL; | ||
| DWORD numPixels = 0; | ||
| FreeImage_AcquireMemory(memory.get(), &pixels, &numPixels); | ||
| return {base64_encode(pixels, numPixels)}; |
There was a problem hiding this comment.
shouldn't this whole block go as a function into ImageUtils?
brayns/common/utils/ImageUtils.h
Outdated
| return true; | ||
| } | ||
|
|
||
| ImagePtr getImageFromFrameBuffer(FrameBuffer& frameBuffer) |
There was a problem hiding this comment.
getImageFromFrameBuffer and SwapRedBlue32 should go into ImageUtils.cpp. You can get compilation errors about double definitions if you try using them in two places, unless the function are inlined, but I don't see a good reason to inline them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.