Use perceptual diff for more robust image comparison in tests #405
+172
−159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribal-tec
force-pushed
the
master
branch
3 times, most recently
from
85c6d36 to
4080d9a
Compare
tribal-tec
changed the title
karjonas
reviewed
Jun 5, 2018
tests/brayns.cpp
Outdated
| @@ -142,11 +147,12 @@ BOOST_AUTO_TEST_CASE(defaults) | |||
| BOOST_CHECK(geomParams.getMemoryMode() == brayns::MemoryMode::shared); | |||
| } | |||
|
|
|||
| #ifdef BRAYNS_USE_FREEIMAGE | |||
| BOOST_AUTO_TEST_CASE(render_two_frames_and_compare_they_are_same) | |||
There was a problem hiding this comment.
Can you move the pdiff-related tests to braynsTestData.cpp or snapshot.cpp to separate them from the others? Then you would not need to use any ifdefs here.
tribal-tec
force-pushed
the
master
branch
6 times, most recently
from
c8bce74 to
bdb33ff
Compare
tribal-tec
force-pushed
the
master
branch
2 times, most recently
from
fb4b569 to
ddc1bce
Compare
favreau
approved these changes
Jun 5, 2018
|
Have to fix the Docker build, hold on... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.