Throw exception if model is empty #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribal-tec
reviewed
May 25, 2018
| @@ -111,6 +111,9 @@ void Scene::clearLights() | |||
|
|
|||
| size_t Scene::addModel(ModelDescriptorPtr model) | |||
| { | |||
| if (model->getModel().empty()) | |||
There was a problem hiding this comment.
The same applies for submodels, so please add this to Model::addModel() as well. I'm about to unify this somewhat duplication of code to add models, but for the time being it would be good to have those checks.
tribal-tec
approved these changes
May 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty models cause issues so throw an exception if they are added to the scene.