Cleanups after introduction of models #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Simplify loading; all done by the loaders now * No longer reset camera after load, only at startup * separate addModel() from createModel() to ease errors in loaders * unify commit and modified handling of the scene * allow concurrent loading and snapshot generation
rolandjitsu
approved these changes
May 8, 2018
|
retest this please |
|
retest this please |
2 similar comments
|
retest this please |
|
retest this please |
|
retest this please |
1 similar comment
|
retest this please |
|
Retest this please |
|
don't merge yet!!! |
|
Retest this please |
tribal-tec
force-pushed
the
master
branch
2 times, most recently
from
d248668 to
919e696
Compare
|
Retest this please |
1 similar comment
|
Retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.