Add support for dynamic plugin loading #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribal-tec
force-pushed
the
master
branch
7 times, most recently
from
3e2b756 to
89c29d4
Compare
tribal-tec
force-pushed
the
master
branch
2 times, most recently
from
bcfdb1d to
0e98ff2
Compare
rdumusc
reviewed
Mar 13, 2018
brayns/CMakeLists.txt
Outdated
| @@ -7,13 +7,15 @@ | |||
| add_subdirectory(parameters) | |||
| add_subdirectory(common) | |||
| add_subdirectory(io) | |||
| add_subdirectory(plugin) | |||
There was a problem hiding this comment.
sure, I renamed it later and noticed we already have pluginS for the built-in ones
tests/braynsTestData.cpp
Outdated
| "stereo"}; | ||
| const char* argv[] = { | ||
| app, "--synchronous-mode", "on", "--accumulation", "off", | ||
| "--pdb-file", pdbFile.c_str(), "--camera", "stereo"}; |
There was a problem hiding this comment.
damn clangformat. It shouldn't be my job :(
There was a problem hiding this comment.
Can't do it. clangformat likes it this way
karjonas
approved these changes
Mar 13, 2018
|
|
||
| void loadPlugins() | ||
| { | ||
| #ifdef BRAYNS_USE_OSPRAY |
There was a problem hiding this comment.
Is it a problem we need to have ospray enabled to load our plugins?
There was a problem hiding this comment.
Today nothing works without having ospray anyways. But for your plugins you don't need/see it. We can also use lunchbox::DSO for the library loading. Or some boost stuff.
favreau
reviewed
Mar 13, 2018
tests/ClientServer.h
Outdated
| client.notify<Params>(method, params); | ||
|
|
||
| wsClient.process(5); | ||
| for (size_t i = 0; i < 10; ++i) |
There was a problem hiding this comment.
Magic numbers 5 and 10? Can you define constants for that with an explicit name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.