Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Topology Viewer plugin with action interface #340

Merged
merged 1 commit into from
Mar 7, 2018

Conversation

karjonas
Copy link
Contributor

@karjonas karjonas commented Mar 7, 2018

Uses the templated addPlugin function for all plugins in Brayns and
removes the duplicate createPlugins function and _actionInterface
variable in the Impl class.

Uses the templated addPlugin function for all plugins in Brayns and
removes the duplicate createPlugins function and _actionInterface
variable in the Impl class.
@karjonas karjonas requested review from tribal-tec and favreau March 7, 2018 10:17
Copy link
Contributor

@tribal-tec tribal-tec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice reuse of addPlugin! I missed that :)

@karjonas karjonas merged commit 187d1bc into BlueBrain:master Mar 7, 2018
@karjonas karjonas deleted the topology_viewer_plugin_fix branch March 7, 2018 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants