Full websocket support; automatic broadcast of modified objects #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tribal-tec
commented
Dec 21, 2017
tribal-tec
commented
- replaced Lexis and ZeroBuf by StaticJSON to allow in-place de-/serialization
- changed endpoints and payloads according to exposed brayns classes
- fixed some race conditions, found by -fsanititze=thread
tribal-tec
force-pushed
the
master
branch
5 times, most recently
from
fa3538c to
a7a525c
Compare
* replaced Lexis and ZeroBuf by StaticJSON to allow in-place de-/serialization * changed endpoints and payloads according to exposed brayns classes * fixed some race conditions, found by -fsanititze=thread
|
@favreau fine with me, shall we merge? |
|
Got the green light from @rolandjitsu and @rdumusc, so yes, ok for me too. |
favreau
approved these changes
Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.