Support image and progress over websockets, minor fixes #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdumusc
approved these changes
Nov 8, 2017
| @@ -126,6 +133,7 @@ class ApplicationParameters : public AbstractParameters | |||
| std::string _streamId; | |||
| std::string _tmpFolder; | |||
| bool _synchronousMode{false}; | |||
| size_t _imageStreamFPS{60}; | |||
There was a problem hiding this comment.
It's just an upper limit. We will never render that fast anyways :)
| _httpServer->broadcastText(message); | ||
| } | ||
|
|
||
| if (_engine->getRenderer().haveNewImage()) |
There was a problem hiding this comment.
hmmm, shouldn't this method be called hasNewImage() instead of haveNewImage()?
There was a problem hiding this comment.
Hmm, true. I'll have to recheck also if this works with Optix.
rolandjitsu
reviewed
Nov 9, 2017
| @@ -179,6 +194,24 @@ class RocketsPlugin : public ExtensionPlugin | |||
| ::brayns::v1::Scene _remoteScene; | |||
| ::brayns::v1::ForceRendering _remoteForceRendering; | |||
| ::brayns::v1::CircuitConfigurationBuilder _remoteCircuitConfigBuilder; | |||
|
|
|||
| class Timer | |||
There was a problem hiding this comment.
Can I ask what's the purpose of this timer?
There was a problem hiding this comment.
To limit the image stream to the configurable image stream FPS. 60 FPS by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.