Enh/docker #238
Merged
Enh/docker #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An intermediate image is used to build Brayns. The delivered image only provides the result of the compilation and runtime libraries. New image size is 437MB! Build time is also improved because there is no need to cleanup the *build* image anymore.
|
"On my way" means that your are still working on it, on not ready for review yet? |
tribal-tec
reviewed
Nov 1, 2017
Dockerfile
Outdated
| ENV LD_LIBRARY_PATH $LD_LIBRARY_PATH:${DIST_PATH}/lib | ||
| ENV PATH $PATH:${DIST_PATH}/bin | ||
|
|
||
| ENV LD_LIBRARY_PATH $LD_LIBRARY_PATH:/app/dist/lib |
There was a problem hiding this comment.
why not reusing DIST_PATH instead of hard-coding /app/dist/lib?
There was a problem hiding this comment.
I agree, just use DIST_PATH.
There was a problem hiding this comment.
- You are right, it should not be hardcoded. I will make the required changes.
- Besides
ENVandARGare not available in other build stages. they must be redefined. - I think we should use
ARGinstead ofENVasDIST_PATHdoes not seem to be a required variable in the container. Anybody against?
|
@tristan0x looks great, I was planning on using multi step builds, but never got the time to do it. |
rolandjitsu
suggested changes
Nov 1, 2017
|
@favreau Regarding BraynViewer, it is still work in progress. |
|
Hello @rolandjitsu |
rolandjitsu
approved these changes
Nov 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my way to make
braynsViewerworks within containers, here is a small contribution to shrink both Docker image size and build time.Image size is now 437MB instead of >1GB
The patch leverages multi-stage builds, a feature released in Docker 17.05.
More information available in the official user guide