Fixed material management #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
favreau
force-pushed
the
master
branch
2 times, most recently
from
a8d17e1 to
9a4c7c3
Compare
tribal-tec
reviewed
May 12, 2017
brayns/common/types.h
Outdated
| @@ -284,15 +283,15 @@ struct Histogram | |||
| /** Some 'special' materials are used by Brayns to acomplish specific features | |||
| * such as skyboxes. | |||
| */ | |||
| const size_t DEFAULT_NB_MATERIALS = 200; | |||
tribal-tec
reviewed
May 12, 2017
| _ospMaterialData = 0; | ||
|
|
||
| // Determine how many materials need to be created | ||
| size_t maxId = -std::numeric_limits<size_t>::max(); |
There was a problem hiding this comment.
shouldn't be min? -max for unsigned overflows to 0 or 1, no?
There was a problem hiding this comment.
hum... yes, 0, definitely :-) Thanks
tribal-tec
approved these changes
May 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, a fixed number of materials was initialized at application start-up. The whole material management has been revisited to allow a dynamic number of elements.