Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed circuit bounding box management #149

Merged
merged 3 commits into from
Apr 21, 2017
Merged

Fixed circuit bounding box management #149

merged 3 commits into from
Apr 21, 2017

Conversation

favreau
Copy link
Member

@favreau favreau commented Apr 13, 2017

No description provided.

@favreau favreau requested review from chevtche and tribal-tec April 13, 2017 13:44
tribal-tec
tribal-tec reviewed Apr 19, 2017
View reviewed changes
brayns/io/MorphologyLoader.cpp Outdated
@@ -995,6 +1030,12 @@ bool MorphologyLoader::importSimulationData(const servus::URI& circuitConfig,
return true;
}

bool MorphologyLoader::_positionInCircuitBoundingBox(const Vector3f& position)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const function?

@hernando
Copy link
Contributor

Aren't you using brain for accessing the circuit data? I have the feeling that if you did your code would be simpler. At the same time, there's no function there to find out the bounding box of the circuit, but it could and maybe should be added.

@favreau
Copy link
Member Author

favreau commented Apr 19, 2017

I am using brain indeed, in the importCircuit methods. What makes you think I am not?

@hernando
Copy link
Contributor

True, now that I look again there're some identifiers inside the brain namespace. I just took a quick look but the lines with mv3support? seemed fishy to me. Why do you have to make a distinction?

@favreau
Copy link
Member Author

favreau commented Apr 20, 2017

I totally agree with you regarding the mvd3support, I did that because I needed to get the layer, m-type, e-type, etc of the neuron and as far as I understand, this is currently only supported in brion. If there is a way to get this information in brain, I am happy to modify the code.

@favreau
Copy link
Member Author

favreau commented Apr 21, 2017

Ping

@favreau favreau merged commit 2447681 into BlueBrain:master Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tribal-tec tribal-tec tribal-tec approved these changes

@chevtche chevtche Awaiting requested review from chevtche

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@favreau @hernando @tribal-tec