Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced enum by enum class, once and for all #148

Merged
merged 2 commits into from
Apr 13, 2017

Conversation

favreau
Copy link
Member

@favreau favreau commented Apr 12, 2017

No description provided.

@favreau favreau requested a review from rdumusc April 12, 2017 16:29
Copy link

@rdumusc rdumusc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, just two little details

FBF_BGRA_I8,
FBF_RGB_I8,
FBF_RGBA_F32,
rgba_none,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is rgba_none? Is it just none?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do idea, that makes no sense :-( I removed it. Probably a left over from some previous experiments. Thanks.

// and light emission
shades_of_grey, // 255 shades of grey
gradient, // Gradient from red to yellow
pastel, // Random pastel colors
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra , after pastel

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed too

@favreau favreau merged commit 414c896 into BlueBrain:master Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants