Skip to content

Feature/picker #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Feature/picker #136

wants to merge 11 commits into from

Conversation

mhusnainnnaseer786
Copy link
Contributor

@mhusnainnnaseer786 mhusnainnnaseer786 commented Oct 24, 2019

Description

This pr will add Picker component in React native paper.

Screenshots (if appropriate):

Screenshot from 2019-10-24 14-14-03

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mhusnainnnaseer786
Copy link
Contributor Author

Sir @artalat ,
If I render children in picker with mode="dialog" | "menu" then it through an error . Because children are of PickerItem type which needs Picker as their Parent and in our case parent is dailog or menu.

@ammarkhan967 ammarkhan967 added enhancement New feature or request Feature something new is added labels Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Feature something new is added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants