This repository was archived by the owner on Jan 2, 2025. It is now read-only.
Use 0-based indexes for line offsets in code chunks #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calyptobai
force-pushed
the
line-indexing-0-based
branch
3 times, most recently
from
97dc935 to
94a56c0
Compare
calyptobai
force-pushed
the
line-indexing-0-based
branch
from
20c0648 to
3503a3b
Compare
This fixes a bug where `proc` and `code` differed; `code` would store code chunks with an open-close (`[start,end)`) range, while `proc` would store code chunks with an open-open range (`[start,end]`). Now, we only store `[start,end)` in order to be more consistent with the default rust `Range` type.
Previously, the logic to check child elements was using `.any`, and thus short-circuiting. Now we use a combination of `map` and `fold`, which exhausts the `.children()` iterator properly.
Now, links like `[foo](foo.rs#L1)` are correctly updated. Note the lack of an end range, like `#L1-L2`.
calyptobai
force-pushed
the
line-indexing-0-based
branch
from
52172f0 to
f3699f0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, we swap the internal line range logic to use 0-based indexes. We make a concession for links, as they are generated directly by the LLM and not normally process, and so we add additional processing to change the indexing base.
In the future, we can test the model with generating 0-based indexes directly, and remove the new extra processing logic if this works.
Closes BLO-1375 and BLO-1390.