Skip to content
This repository was archived by the owner on Jan 2, 2025. It is now read-only.

Conversation

@calyptobai
Copy link
Contributor

To enforce consistency, we now use forward slashes (/) throughout the app, on both unix and Windows platforms.

To enforce consistency, we now use forward slashes (`/`) throughout the
app, on both unix and Windows platforms.
@calyptobai calyptobai requested a review from ggordonhall July 27, 2023 23:33
@oppiliappan
Copy link
Contributor

the File index contains an is_directory field, could we use that to classify documents instead of the trailing slash notation?

@ggordonhall ggordonhall requested a review from oppiliappan July 28, 2023 07:25
Copy link
Contributor

@oppiliappan oppiliappan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, comments can be tackled in a later PR.

@oppiliappan oppiliappan merged commit aeba010 into main Jul 28, 2023
@oppiliappan oppiliappan deleted the fix-windows-path-browsing branch July 28, 2023 08:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants