This repository was archived by the owner on Jan 2, 2025. It is now read-only.
Local repositories without remotes were incorrectly indexed #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsdy
force-pushed
the
rsdy/blo-1334-local-repositories-without-remote-branches-dont-sync
branch
from
7932920 to
b29da63
Compare
rsdy
requested review from
ggordonhall and
oppiliappan
and removed request for
ggordonhall
This resulted in branch filters messing up queries and making it impossible to get results from purely local repos
rsdy
force-pushed
the
rsdy/blo-1334-local-repositories-without-remote-branches-dont-sync
branch
from
b29da63 to
09ef561
Compare
oppiliappan
approved these changes
Jul 28, 2023
Contributor
oppiliappan
left a comment
oppiliappan
left a comment
There was a problem hiding this comment.
lgtm, fixes bug in indexing repos without remotes.
rsdy
deleted the
rsdy/blo-1334-local-repositories-without-remote-branches-dont-sync
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resulted in branch filters messing up queries and making it impossible to get results from purely local repos.
In this patch, the detection of whether or not it's a Git repository is changed from looking for a Git remote (which may not exist), to simply checking if it's a Git repository at all by signaling if we have detected a last commit timestamp.
Additionally, add explicit support local repositories in the Git file iterator so we only force remote branches when it's a remote repository.