This repository was archived by the owner on Jan 2, 2025. It is now read-only.
Re-introduce HyDE, work around batched calls #735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggordonhall
force-pushed
the
batch-search-workaround
branch
from
7b16947 to
c788683
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We work around the issues present before, by avoiding
batchsearches in qdrant. It is not clear what the problem is currently, but those calls tend to throw HTTP2 stream errors when testing in cloud deployments. Given the volume of documents tends not to be very large, we can buffer a set of non-batched calls instead.