Skip to content
This repository was archived by the owner on Jan 2, 2025. It is now read-only.

Conversation

@calyptobai
Copy link
Contributor

@calyptobai calyptobai commented Jul 4, 2023

In this PR we simplify the answer module, and clean up the Exchange-related data types. Now, the Agent struct is used to drive conversations instead of Conversation, and it holds surrounding conversation context, such as thread IDs and LLM gateway clients.

Of note:

  • Exchange has been reorganized and simplified
    • Outcome replaces the old enum Results
    • finished has been removed, and can now be inferred by the closing of a stream
    • SearchResult has been renamed to FileAction, and all associated *Result types were renamed to *Action
  • Conversation methods related to agent tasks were split into a new Agent type
  • Methods related to the LLM gateway were moved from AppContext to llm_gateway::Client
  • The AppContext struct was merged into Agent
  • The CancellationTrack struct was merged into Agent

@calyptobai calyptobai marked this pull request as ready for review July 5, 2023 14:21
Copy link
Contributor

@ggordonhall ggordonhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this, nice and clean

@calyptobai calyptobai merged commit 4c85ff0 into main Jul 5, 2023
@calyptobai calyptobai deleted the exchange-cleanup branch July 5, 2023 17:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants