This repository was archived by the owner on Jan 2, 2025. It is now read-only.
Windows builds 2 #714
Merged
Windows builds 2 #714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calyptobai
reviewed
Jun 30, 2023
ggordonhall
previously requested changes
Jul 1, 2023
Contributor
ggordonhall
left a comment
ggordonhall
left a comment
There was a problem hiding this comment.
The server does not start on the aarch64-apple-darwin build.
rsdy
force-pushed
the
windows-builds2
branch
6 times, most recently
from
ce65f31 to
48beee9
Compare
ggordonhall
approved these changes
Jul 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would be helpful to get an acceptance test on all platforms before merging.