This repository was archived by the owner on Jan 2, 2025. It is now read-only.
Catch non-existent paths in single file answer contexts #704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oppiliappan
approved these changes
Jun 30, 2023
| query: Box<dyn tantivy::query::Query>, | ||
| searcher: tantivy::Searcher, | ||
| ) -> Result<ContentDocument> { | ||
| ) -> Result<Option<ContentDocument>> { |
Contributor
There was a problem hiding this comment.
i think we could structure the return type a bit better in a future PR; top_hit (and its descendant functions file_body and by_path) can:
- return 0 docs if there are no results
- exactly 1 doc
- more than 1 doc if there are duplicates in the index
in this PR it is modeled as:
Ok(None): zero resultsOk(Some(_)): one resultErr(_): many results
but this might be nicer if we use error enum variants for each scenario.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.