Skip to content
This repository was archived by the owner on Jan 2, 2025. It is now read-only.

Conversation

@calyptobai
Copy link
Contributor

No description provided.

@anastasiya1155
Copy link
Collaborator

anastasiya1155 commented Jun 22, 2023

When is the identify call made? Preferably should be done after GitHub login or on launch
Also, besides user_id, we need to include:

is_self_serve: boolean, // is it cloud of tauri
github_username: string, // can be empty if not logged in
org_name: string, // GitHub organisation name for cloud users
device_id: string, // shouldn't have a trailing new line, currently trimmed on the FE

@anastasiya1155
Copy link
Collaborator

For upvote route we need query_id, but FE doesn't know it. It is not present in answer stream

@calyptobai
Copy link
Contributor Author

@anastasiya1155 The identify call is now made on first login. Do we want it to also occur on a specific route, for users which are already logged in? It should now include the parameters you noted, though user_id is user_name.

Additionally:

For upvote route we need query_id, but FE doesn't know it. It is not present in answer stream

The first message sent back from /answer has been changed from a thread ID string to an initialization object of the form:

{
    "thread_id": "...",
    "query_id": "...",
}

also, should accept (and track in analytics) the user comment left when downvoting the response

Now, .../vote replaces positive: boolean with a feedback parameter in the forms:

{"type":"positive"}
{"type":"negative","feedback":"..."}

@anastasiya1155
Copy link
Collaborator

I still don't see the 'identify' call in the analytics panel. Are you sure it is triggered in Tauri? As far as I remember login flow on the cloud and in Tauri differs.

@anastasiya1155
Copy link
Collaborator

I don't see any events for repo indexed/removed in the analytics console. fyi the FE uses delete /repos/indexed and get /repos/sync endpoints for managing repos

@calyptobai
Copy link
Contributor Author

I still don't see the 'identify' call in the analytics panel. Are you sure it is triggered in Tauri? As far as I remember login flow on the cloud and in Tauri differs.

We should now track successful logins with /remotes/github/login.

I don't see any events for repo indexed/removed in the analytics console. fyi the FE uses delete /repos/indexed and get /repos/sync endpoints for managing repos

Deletions are now tracked via DELETE /repos/indexed. Addition is tracked as part of PUT /repos/indexed.

@calyptobai calyptobai marked this pull request as ready for review June 29, 2023 16:48
@anastasiya1155
Copy link
Collaborator

We need to do some tweaks to identify call:

  • device_id shouldn't have a trailing newline (previously was trimmed on the FE)
  • user_id should be the same as tracking_id from /config endpoint previously used by FE
  • github_username should be in traits
Screenshot 2023-06-29 at 20 52 57

@anastasiya1155
Copy link
Collaborator

I don't see events for repo adding/removing in the analytics console

@calyptobai
Copy link
Contributor Author

We need to do some tweaks to identify call:

  • device_id shouldn't have a trailing newline (previously was trimmed on the FE)
  • user_id should be the same as tracking_id from /config endpoint previously used by FE
  • github_username should be in traits

I don't see events for repo adding/removing in the analytics console

These should now be addressed.

@ggordonhall ggordonhall merged commit 0e4bb24 into main Jun 30, 2023
@ggordonhall ggordonhall deleted the analytics-updates branch June 30, 2023 07:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants