Skip to content
This repository was archived by the owner on Jan 2, 2025. It is now read-only.

Conversation

@calyptobai
Copy link
Contributor

@calyptobai calyptobai commented May 26, 2023

Due to our integration of sentry_tracing, error! logs are captured as sentry errors. We propagate additional information like message history using breadcrumbs generated by debug!.

@calyptobai calyptobai requested a review from oppiliappan May 26, 2023 12:07
@calyptobai calyptobai force-pushed the sentry-http-400 branch 2 times, most recently from 17a9259 to 33cffa3 Compare May 30, 2023 00:22
@calyptobai calyptobai requested a review from ggordonhall May 30, 2023 00:23
@ggordonhall
Copy link
Contributor

Import error then lgtm

Copy link
Contributor

@rsdy rsdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the style could be improved. It may also be helpful to instrument the whole function to get scoped errors for debugging.

@calyptobai calyptobai merged commit dd2b7fc into main May 30, 2023
@calyptobai calyptobai deleted the sentry-http-400 branch May 30, 2023 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants