This repository was archived by the owner on Jan 2, 2025. It is now read-only.
ignore non-blob objects in git file sources #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sometimes tree-like objects would enter this function, and result in
their object data being read into a buffer (they are not utf8 strings);
producing funny looking buffer data:
40000 ISSUE_TEMPLATEoDW$yhQ��M��\fX��V�40000 workflows�\nk��$�*^c���0N*7
inspecting the object in git shows that it is a tree and not a blob:
λ git cat-file -t 3f8a07d
tree
λ git cat-file -p 3f8a07d
040000 tree 6f44572 ISSUE_TEMPLATE
040000 tree ee0a6b1 workflows
rsdy
approved these changes
May 24, 2023
ggordonhall
added a commit
that referenced
this pull request
May 24, 2023
This reverts commit 001ca9f.
ggordonhall
added a commit
that referenced
this pull request
May 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sometimes tree-like objects would enter this function, and result in their object data being read into a buffer (they are not utf8 strings); producing funny looking buffer data:
inspecting the object in git shows that it is a tree and not a blob: