This repository was archived by the owner on Jan 2, 2025. It is now read-only.
introduce new import node
#499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`import`s are both definitions (the introduction of a name to a syntax tree) and references (they refere to a name outside this syntax tree). this should help improve cross-file navigation using the following heuristics: - the definition of a name can exclude imports in cross-file navigation by default - if no definition exists for a name across the entire repo, this name is an externally definied name, we can mark its import node in the same syntax-tree (or file) as its definition node
oppiliappan
force-pushed
the
scope-res-imports
branch
from
c651f1c to
6e1d411
Compare
- do not search for definitions in other files if present locally
ggordonhall
approved these changes
May 19, 2023
Contributor
ggordonhall
left a comment
ggordonhall
left a comment
There was a problem hiding this comment.
On the whole this works well. There are still some cases that we need to think about, but can take these on in future PRs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imports are both definitions (the introduction of a name to a syntax tree) and references (they refere to a name outside this syntax tree).this should help improve cross-file navigation using the following heuristics: