Skip to content
This repository was archived by the owner on Jan 2, 2025. It is now read-only.

Conversation

@ggordonhall
Copy link
Contributor

The filesystem walker was using the default ignore::Walk struct and therefore ignored hidden files, including the useful .github, .eslint etc.

@ggordonhall ggordonhall requested review from oppiliappan and rsdy May 9, 2023 08:04
Copy link
Contributor

@oppiliappan oppiliappan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, left some optional comments.

ggordonhall and others added 2 commits May 9, 2023 11:40
Co-authored-by: Akshay <nerdy@peppe.rs>
Co-authored-by: Akshay <nerdy@peppe.rs>
Copy link
Contributor

@rsdy rsdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice & clean.

@ggordonhall ggordonhall merged commit 847fd47 into main May 9, 2023
@ggordonhall ggordonhall deleted the gabriel/index-hidden-files branch May 9, 2023 11:07
ggordonhall added a commit that referenced this pull request May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants