This repository was archived by the owner on Jan 2, 2025. It is now read-only.
Remove git2 in favour of gitoxide #432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggordonhall
approved these changes
Apr 27, 2023
Contributor
ggordonhall
left a comment
ggordonhall
left a comment
There was a problem hiding this comment.
This looks good. Much cleaner, and lots of nice new error types.
I have tested this on desktop, but not with GitHub App credentials.
Contributor
|
/build |
|
🟢 Bloop container with |
calyptobai
added a commit
that referenced
this pull request
Jun 30, 2023
* Pin Rust toolchain and vendor OpenSSL Based on our `flake.nix` file, it seems we have the following runtime dependencies: `openssl.out rocksdb git zlib nsync onnxruntime14`. Judging from our own `Cargo.lock`, and examining qdrant's `Cargo.lock`, we know that: - [`rocksdb` is built statically and not needed at runtime](https://github.com/rust-rocksdb/rust-rocksdb/blob/master/librocksdb-sys/Cargo.toml#L16) (unless provided by environment variables, which we don't do in default builds) - [`zlib` is not used as default features are deactivated](https://github.com/qdrant/qdrant/blob/master/lib/segment/Cargo.toml#L28) - [We removed `libgit2` in favor of `gitoxide`](#432) - [We pin `onnxruntime` versions to specific binaries provided by `ort`](#231) We also add a Rust toolchain configuration to pin the toolchain at `1.70.0`, and ensure that `openssl-sys` is built statically using the `vendored` feature. This removes all remaining non-platform-specific runtime dependencies except `nsync`, which does not seem to be linked into either `bloop` builds or `qdrant`'s builds. * Upgrade deps, use rustls --------- Co-authored-by: rsdy <p@symmetree.dev>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.