This repository was archived by the owner on Jan 2, 2025. It is now read-only.
Use GitHub username or id to identify #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggordonhall
reviewed
Apr 5, 2023
Contributor
There was a problem hiding this comment.
Will we need to make some changes to answer.rs and analytics.rs to propagate the user identifier into the analytics DB? At the moment the frontend passes a user_id to /answer.
@anastasiya1155 I'd like to get your input on this. What is the user_id passed to /answer?
Collaborator
We use unique device id as a user identifier at the moment |
oppiliappan
approved these changes
Apr 6, 2023
Contributor
oppiliappan
left a comment
oppiliappan
left a comment
There was a problem hiding this comment.
this also opens up the gates for adding gh user-ids in analytics events!
rsdy
changed the title
ggordonhall
approved these changes
Apr 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a persistent tracking_id that's user-aware. The core of the logic is in
webserver/config.rs, and would be good to get another pair of eyes if this is what we want.This also opens the opporunity to potentially reset this in the future on a per-user basis, but that's unimplemented currently.