Skip to content
This repository was archived by the owner on Jan 2, 2025. It is now read-only.

supress panics from remotes::poll #309

Merged
oppiliappan merged 1 commit into from
Mar 23, 2023
Merged

supress panics from remotes::poll #309

oppiliappan merged 1 commit into from
Mar 23, 2023

Conversation

@oppiliappan
Copy link
Contributor

@oppiliappan oppiliappan commented Mar 22, 2023 •
edited
Loading

  • initializing the file watcher can panic if the repo is moved/deleted after the scan and before the poller starts (i think so, hard to repro)
  • the cause channel send failures is still unknown to me, any idea how the channel may end up closed or similar?

@oppiliappan oppiliappan requested a review from rsdy March 22, 2023 09:59
@oppiliappan oppiliappan merged commit 3f9a149 into main Mar 23, 2023
@oppiliappan oppiliappan deleted the avoid-panics-poller branch March 23, 2023 11:11
rsdy pushed a commit that referenced this pull request Mar 23, 2023
@oppiliappan @rsdy
supress panics from remotes::poll (#309)
20d3d06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@rsdy rsdy rsdy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oppiliappan @rsdy