Skip to content

Disable image "Become background" on standard cover pages (BL-16130) #7824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StephenMcConnel wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −0
Open

Disable image "Become background" on standard cover pages (BL-16130) #7824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/BloomBrowserUI/bookEdit/js/CanvasElementContextControls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1699,6 +1699,15 @@ function addImageMenuOptions(
);
};

// The "Become background" option is not available for standard cover pages.
const customLayoutablePage = canvasElement.closest(
".bloom-page[data-custom-layout-id]",
);
const isStandardCoverPage =
(customLayoutablePage &&
!customLayoutablePage.classList.contains("bloom-customLayout")) ??
false;

const realImagePresent = hasRealImage(img);
const imageMenuOptions: IMenuItemWithSubmenu[] = [
{
Expand Down Expand Up @@ -1818,6 +1827,7 @@ function addImageMenuOptions(
imageMenuOptions.push({
l10nId: "EditTab.Toolbox.ComicTool.Options.BecomeBackground",
english: "Become Background",
disabled: isStandardCoverPage,
onClick: () => {
const bloomCanvas = canvasElement.closest(
kBloomCanvasSelector,
Expand Down