ci: Backport MSan fixes for ctime_tests #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
to make it more promiment
|
Great that you've figured out the right commits to backport! These are so old that I had forgotten about them. (Which just tells how long we haven't synced with upstream...) |
The macOS 12 GHA image has been deprecated since 2024-10-07. See: actions/runner-images#10721
BEULAHEVANJALIN
force-pushed
the
fix-ci-ctime-failures
branch
from
18254c2 to
b9a82b4
Compare
jonasnick
approved these changes
Sep 19, 2025
real-or-random
merged commit 42e75b6
into
BlockstreamResearch:master
224 of 227 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked the upstream fixes from bitcoin-core/secp256k1#1517 to align behaviour here and silence the false 'use-of-uninitialized-value' reports in ctime_tests under Clang ≥16.
Result:
ctime_testsis clean under MSan.Commits cherry-picked:
References:
Upstream: bitcoin-core/secp256k1#1517