Mention batched updates in multi-hop locks #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This text update clarifies my concern, specifically the text "the adversary should not be able to trick the victim into signing a transaction with a different nonce." Thanks! |
jonasnick
force-pushed
the
batched-updates
branch
from
5a5e3b4 to
4e6e4bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some concern around a Wagner's attack when using batched updates in MuSig based multi-hop locks. If this was true we'd need to add another round of communication. But I don't see how the attack would work (perhaps I'm misunderstanding it), which is why I added a paragraph explaining why Wagner's attack does not apply.
CC @harding @ZmnSCPxj