Skip to content

Conversation

stevenroose
Copy link

I'm not sure if those stability tests etc are ran in CI. I'll let CI run and please let me know if manual testing is advised. It won't work with versions before 28.0-rc anyway.

Is there a common practice here for what to do when an api endpoint requires a certain daemon version? I guess now the node will throw an error and it will just be propagated upwards to the user.

@tnull
Copy link

tnull commented Oct 28, 2024

I highly appreciate the effort to add submitpackage support to the Esplora protocol, as we Lightning devs want to lean on it being available soon. Given that there are multiple forks, should there be some coordination across projects to make sure the endpoints remain interoperable and usable by the same clients, e.g., rust-esplora-client?

See for example mempool/electrs#105 which seems to use another endpoint (txs/package) that would be incompatible to the one chosen here, IIUC?

@stevenroose
Copy link
Author

Hey, I agree with your proposed endpoints in mempool/electrs#105 and will happily adapt mine to that :) I might even adopt your implementation :)

@wiz
Copy link

wiz commented Nov 1, 2024

based on the comments by @stevenroose to adopt mempool/electrs#105 we will go ahead and merge that cc @moneyball

@tnull
Copy link

tnull commented Nov 1, 2024

Hey, I agree with your proposed endpoints in mempool/electrs#105 and will happily adapt mine to that :) I might even adopt your implementation :)

Sounds like we're aligned on an API then. Thanks for resolving this! :)

@stevenroose stevenroose force-pushed the submit-tx-package branch 2 times, most recently from e5aa76c to a9a39b1 Compare January 21, 2025 15:53
@stevenroose
Copy link
Author

Hi all, I (finally, my apologies) adapted this PR to resemble the same REST endpoint and response as what @wiz added for mempool.

@shesek is it ok if the internal mempool handling is done in a separate PR? It's seems to require a little bit of a non-trivial refactor and I don't really have the time. I would prefer that to not block having this endpoint added.

Also rebased to resolve some conflict.

@stevenroose stevenroose changed the title Add /txs endpoint to submit tx packages Add /txs/package endpoint to submit tx packages Jan 22, 2025
@stevenroose
Copy link
Author

@shesek any update on this??

@RobinLinus
Copy link

Any updates on this?

@tnull
Copy link

tnull commented Jul 31, 2025

Any update on this?

@RCasatta
Copy link
Collaborator

ACK 9a4175d

added test in #159

@RCasatta
Copy link
Collaborator

merged via #159

@RCasatta RCasatta closed this Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants