-
Notifications
You must be signed in to change notification settings - Fork 152
Add /txs/package endpoint to submit tx packages #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I highly appreciate the effort to add See for example mempool/electrs#105 which seems to use another endpoint ( |
Hey, I agree with your proposed endpoints in mempool/electrs#105 and will happily adapt mine to that :) I might even adopt your implementation :) |
based on the comments by @stevenroose to adopt mempool/electrs#105 we will go ahead and merge that cc @moneyball |
Sounds like we're aligned on an API then. Thanks for resolving this! :) |
e5aa76c
to
a9a39b1
Compare
Hi all, I (finally, my apologies) adapted this PR to resemble the same REST endpoint and response as what @wiz added for mempool. @shesek is it ok if the internal mempool handling is done in a separate PR? It's seems to require a little bit of a non-trivial refactor and I don't really have the time. I would prefer that to not block having this endpoint added. Also rebased to resolve some conflict. |
a9a39b1
to
9a4175d
Compare
@shesek any update on this?? |
Any updates on this? |
Any update on this? |
merged via #159 |
I'm not sure if those stability tests etc are ran in CI. I'll let CI run and please let me know if manual testing is advised. It won't work with versions before 28.0-rc anyway.
Is there a common practice here for what to do when an api endpoint requires a certain daemon version? I guess now the node will throw an error and it will just be propagated upwards to the user.